Bookmark and Share

Notice: On April 23, 2014, Statalist moved from an email list to a forum, based at

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: st: Re: calculating proportions

From   Oliver Jones <>
Subject   Re: st: Re: calculating proportions
Date   Wed, 22 Feb 2012 11:18:45 +0100

I'm not sure how well Ekaterina knows the characteristics of local macros...
Maybe at this point it helps to say that a local macro which is defined by execution of a .do-file stops to exist after the .do-file is finished.

If you (Ekaterina) are unsure what I mean, try the following:

1. open the dofile editor, write the following two lines and execute them
local our_test_macro "defined interactively"
dis "The macro our_test_macro contains: `our_test_macro'"

2. Now go to the command line and type
dis "The macro our_test_macro contains: `our_test_macro'"


Am 21.02.2012 19:31, schrieb Nick Cox:
No, that's not what I said. It's the opposite, if anything.

In more general terms: we can't comment on code that you don't show
us. Your previous mail could be read as implying that there was a
problem with the code using local macros posted by others. My point is
that there wasn't a problem of that kind. If there was a problem with
local macros, it lay in your translation of the code.

However, various other questions remain up in the air. The code you
are using loops over observations. It is evident from looking at the
code for -relrank- (SSC) that no such approach is necessary, but if
your problem is solved you may not mind about that, but I wouldn't
want this thread to fade away without making that point.


On Tue, Feb 21, 2012 at 6:20 PM, Ekaterina Hertog
<>  wrote:
Dear Nick,
thanks a lot for the pointer.
I must have had N_female defined earlier. Once I dropped all macros, it

On 21/02/2012 17:33, Nick Cox wrote:

There are various possible reasons for a problem here with what
Ekaterina did, including

1. No local macro N_female was defined by her earlier.

2. One such was defined by her but is not visible to Stata at that point.

The use of local macros looks fine in the code posted by Pathmes and


On Tue, Feb 21, 2012 at 5:22 PM, Ekaterina Hertog
<>    wrote:

Dear Pathmes and Oliver,
thanks a lot, great code and it solves my problems! And I learned more
3 things from it
Just a small hitch:
converting numbers to proportions syntax:

gen fap=fa/`N_female'

gives an error message: 'invalid syntax'.
I went around it by creating a variable which is a constant and equals a
total number of women in the population and using it instead of the local
macro. I clumsy way to do it.

On 21/02/2012 16:45, Pathmeswaran wrote:

Thanks Oliver.

With your help I was able to learn 3 things on my first day in

   indentation in foreach/ forvalue loops

*************** example code begins **************************

version 8
clear all
set obs 7

gen byte id = _n

gen byte sex = 1
replace sex = 0 in 4/7
label def lbl_sex 0 "male" 1 "female"
label values sex lbl_sex

gen int income = 7
replace income = 10 in 3
replace income = 0 in 4
replace income = 7 in 5
replace income = 9 in 6
replace income = 11 in 7


* I have just copied Oliver's code

sort sex
gen idm=_n if sex==0
* idm is a unique number for each male

gen fa=.
label variable fa "Number of females with higher income"

gen fb=.
label variable fb "Number of females with lower income"

gen fe=.
label variable fe "Number of females with equal income"

* The variables fa, fb&      fe are generated individually for each male
in the following loop
        count if sex == 0
        local N_male = `r(N)'

        count if sex == 1
        local N_female = `r(N)'

        forvalues i = 1/`N_male' {
                egen int feabove = rank(income) if sex==1 | (sex==0&
  idm==`i'), field
                replace fa= feabove - 1 if idm==`i'
                drop feabove

                egen int febelow = rank(income) if sex==1 | (sex==0&
  idm==`i'), track
                replace fb=  febelow - 1 if idm==`i'
                drop febelow

                replace fe=`N_female' - ( fa+ fb) if idm==`i'

* Converting the numbers to proportions

gen fap=fa/`N_female'
label variable fap "Proportion of females with higher income"

gen fbp=fb/`N_female'
label variable fbp "Proportion of females with lower income"

gen fep=fe/`N_female'
label variable fep "Proportion of females with equal income"

**************** example code ends ***************************

*   For searches and help try:

Universität Bielefeld
Fakultät für Wirtschaftswissenschaften
Lehrstuhl für Ökonometrie und Statistik
- -
Bielefeld University
Faculty of Business Administration and Economics
Chair of Econometrics and Statistics
- -
Raum / room:  V9-110
Tel / phone:  +49 (0)521 106 12801
- -
*   For searches and help try:

© Copyright 1996–2018 StataCorp LLC   |   Terms of use   |   Privacy   |   Contact us   |   Site index