Bookmark and Share

Notice: On April 23, 2014, Statalist moved from an email list to a forum, based at statalist.org.


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: st: Minor bug in -labvalclone- by NJC


From   Nick Cox <[email protected]>
To   "[email protected]" <[email protected]>
Subject   Re: st: Minor bug in -labvalclone- by NJC
Date   Sat, 23 Nov 2013 16:10:47 +0000

<>

The bug Sergiy reported is now fixed in the version of -labvalclone-
on SSC. (-labvalclone- is part of the -labutil- package.)

Thanks to Sergiy for pointing this out and Kit Baum for putting it up.
Nick
[email protected]


On 22 November 2013 01:04, Nick Cox <[email protected]> wrote:
> Thanks to Sergiy for the public heads-up.
>
> I will get it fixed.
> Nick
> [email protected]
>
>
> On 22 November 2013 00:45, Sergiy Radyakin <[email protected]> wrote:
>> Bug in -labvalclone- by NJC
>> http://fmwww.bc.edu/repec/bocode/l/labvalclone.ado
>>
>> ===Example:
>> clear
>> label define a 1 "US" 2 "UK" 3 "UA"
>> labvalclone a aa
>>
>> ===Output:
>> unrecognized command:  laabel
>> r(199);
>>
>> ===Why does it happen:
>> Because replacing blindly code is not safe. Nick is trying to check
>> for this problem by having a safety check of the old argument earlier
>> in the program:
>> if "`old'" == "label" | "`old'" == "define"
>> but later is doing a replacement of a SUBSTRING, not a WORD-by-word replacement.
>>
>> ===Suggested fix:
>> Simply flank both args (old and new) with spaces:
>> local line: subinstr local line " `old' " " `new' "
>>
>> Best,
>>    Sergiy Radyakin
>> *
>> *   For searches and help try:
>> *   http://www.stata.com/help.cgi?search
>> *   http://www.stata.com/support/faqs/resources/statalist-faq/
>> *   http://www.ats.ucla.edu/stat/stata/
*
*   For searches and help try:
*   http://www.stata.com/help.cgi?search
*   http://www.stata.com/support/faqs/resources/statalist-faq/
*   http://www.ats.ucla.edu/stat/stata/


© Copyright 1996–2018 StataCorp LLC   |   Terms of use   |   Privacy   |   Contact us   |   Site index