[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

st: RE: RE: nested forvalues loop

From   "Nick Cox" <>
To   <>
Subject   st: RE: RE: nested forvalues loop
Date   Mon, 5 Oct 2009 12:35:35 +0100

In order to give further advice, I think we'd need to see exactly what
code you used and what you mean by "did not return any value". This is a
standard Statalist request. 


(thread is edited) 

Ariel Linden

Thank you for reviewing my code. I tried running it and it did not
any value for any of the ps`j' 

This code is supposed to use the current and lagged months covariates in
logistic model to account for past treatment and covariate history.

So, given that context, I would like to loop at each month,
the lags of all prior months starting at month 14, working up to the end
the last period (month 24). Month 14 will only have 1 lag (this is where
month 13 data comes in), while month 24 will contain covariate values
month 13 all the way up to month 24.

"Nick Cox" <>

There is some inconsistency here over whether you want to start at 13 or

Your -predict- command won't work. Second time around the inner loop,
ps`i' already exists. 

Here's a guess at better code. 

forvalues j=1/10 {
	gen ps`j' = . 
	forvalues i=14/24 {
		capture logit  Y l(0/`j').X1 l(0/`j').X2 l(0/`j').X3
month if month==`i'
		if _rc == 0 { 
			tempvar work
			predict `work' 
			replace ps`j' = `work' if month == `i'
			drop `work'
Ariel Linden

I have a basic question about structuring this nested forvalues loop

I have a panel data set and I want to focus on months 13 thru 24. In
loop I want to use the lagged values for all the prior months. So I have
which loops through the months 13 thru 24, and `j' that is intended to
increase the lag at each iteration.

For example month 14 should have 0/1 lag and month 24 should have 0/10

I would appreciate feedback as to if I wrote this correctly. 

forvalues i=14/24 {

	forvalues j=1/10 {

capture logit  Y l(0/`j').X1 l(0/`j').X2 l(0/`j').X3 month if month==`i'

predict ps`i' if month == `i'

*   For searches and help try:

© Copyright 1996–2017 StataCorp LLC   |   Terms of use   |   Privacy   |   Contact us   |   What's new   |   Site index